Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osfamily keys have to be a strings? #16

Closed
finderbox-jenkins opened this issue Apr 13, 2015 · 3 comments
Closed

osfamily keys have to be a strings? #16

finderbox-jenkins opened this issue Apr 13, 2015 · 3 comments

Comments

@finderbox-jenkins
Copy link

I had to change in manifests/params.pp line 10:

$service_file  = $::osfamily? {
    Debian => 'wildfly-init-debian.sh',
    RedHat  => 'wildfly-init-redhat.sh',
    default => 'wildfly-init-redhat.sh',
}

to

$service_file  = $::osfamily? {
    'Debian' => 'wildfly-init-debian.sh',
    'RedHat'  => 'wildfly-init-redhat.sh',
    default => 'wildfly-init-redhat.sh',
}

I am not sure if it has something to do with the puppet version I use (3.7.4). And I have not tested RedHat an default, so i did not want to open a pull request as I am not sure about this change.

@finderbox-jenkins finderbox-jenkins changed the title osfamily has to be a string osfamily keys have to be a strings? Apr 13, 2015
@biemond
Copy link
Collaborator

biemond commented Apr 13, 2015

thanks,

I was only testing it on fedora or CentOS , so probably it will use the default branch instead of the Redhat.

And you are right I am also doing this in some other modules.
I will fix it and push a new version.

Thanks again

@biemond
Copy link
Collaborator

biemond commented Apr 13, 2015

Done, I pushed a new version to github and forge.
Can you check this for me if it works on Debian.

@tandibar
Copy link

Yeah, i just testes the current master and it works perfectly. Thanks a lot for the quick response time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants