Fix title patterns to not use unsupported proc #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @treydock ! Can you take a look at the failing rubocop job? |
treydock
force-pushed
the
fix-title-patterns
branch
from
b0db4c1
to
d61fb5c
Compare
This change will allow `puppet generate types` to function Error: ``` Error: /etc/puppetlabs/code/environments/production/modules/windows_env/lib/puppet/type/windows_env.rb: title patterns that use procs are not supported. ``` https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416 treydock/puppet-module-keycloak#21
treydock
force-pushed
the
fix-title-patterns
branch
from
d61fb5c
to
8a156ca
Compare
|
@bastelfreak Fixed failing job |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow
puppet generate typesto functionError:
https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416
treydock/puppet-module-keycloak#21