server_logtype should be optional

[trenta]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 6.12.0
• Ruby:
• Distribution: Ubuntu 18.04
• Module version: 8.0.0

Currently server_logtype is set by the module with no user option available. I'd like to set it to file rather than system.

[baurmatt]

Hey @trenta,

thanks for opening this issue! :) I see that the parameter server_logtype can be configured at the zabbix::server class and you can set it to file.

https://github.com/voxpupuli/puppet-zabbix/blob/master/manifests/server.pp#L313

What exactly are you missing?

[trenta]

So that parameter is taken from this if statement https://github.com/voxpupuli/puppet-zabbix/blob/master/manifests/params.pp#L283

So if the systemd fact returns true then server_logtype is set to system and can't be set by the user.

[baurmatt]

That‘s agent_logtype your‘re linking to. Do you mean agent_logtype or server_logtype?

[trenta]

Sorry yes

puppet-zabbix/manifests/params.pp

Line 178 in dce7c92

$server_logtype = 'system'

.

All over the place this morning :)

[baurmatt]

No worries, just wanted to be sure! :)

server_logtype can be configured like this:

class { "zabbix::server":
  server_logtype => "file",
}

[trenta]

Thanks for your help. Can't believe I missed that. For the server I'd still be configuring things in the zabbix class.

[trenta]

Yeah to just to confirm if you want to use the zabbix class for a single server setup you can't alter this value so I'd have to change to the following explicit setup so I can set that value?

zabbix::web
zabbix::server
zabbix::database