Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Modal />の命名を変更する #180

Closed
youchann opened this issue Sep 17, 2020 · 1 comment
Closed

<Modal />の命名を変更する #180

youchann opened this issue Sep 17, 2020 · 1 comment
Labels
breaking change

Comments

@youchann
Copy link
Contributor

現状は背景となる部分のUIしか存在しないので<Backdrop />みたいな名前が妥当ではなかろうか。

https://material-ui.com/components/backdrop/
@youchann
Copy link
Contributor Author

と思ったが、Material-UIをみた感じだと、良さそう。

背景描画の部分を<BackDrop />として切り出す方向性に。

@youchann youchann closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@youchann