This repository has been archived by the owner on Jan 19, 2018. It is now read-only.
Fix kubernetes provider #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpavlin
added a commit
that referenced
this pull request
May 7, 2015
Needs some minor changes, I will do them after merge
cdrage
added a commit
to cdrage/atomicapp
that referenced
this pull request
Mar 1, 2016
fix wordpress docker artifact - add missing port mapping
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enable kubernetes apps to be deployed when run from a host with the kubectl client. I tested both the fedora and centos Dockerfiles.
One caveat is that the kubernetes bindmounts will cause failures if kubectl is not install on the host. We are mounting
-v /:/host--a bit overkill--so we could add some logic in the code to check if the target provider is installed.