Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test LoadUniVRM fails #24

Closed
bertt opened this issue Sep 4, 2019 · 2 comments
Closed

Unit test LoadUniVRM fails #24

bertt opened this issue Sep 4, 2019 · 2 comments

Comments

@bertt
Copy link
Contributor

bertt commented Sep 4, 2019

Hi, I've noticed the unit test LoadUniVRM() fails. think because the tested file AliciaSolid_vrm-0.40.vrm has validation errors.

@vpenades
Copy link
Owner

vpenades commented Sep 4, 2019

Yes, I've been adding more validation checks, and it seems that file has malformed morph targets.

I've already reported it here: vrm-c/UniVRM#315

@vpenades
Copy link
Owner

vpenades commented Sep 4, 2019

There's a general problem with glTF today, we could say there's two opposing forces:

On one side, you have developers that want to get working with glTF as soon as possible, so they skip a lot of validations when writing files.

On the other, glTF readers expect the files to be valid.

So in an environment full of invalid glTF files, you have two options:

  1. Be strict and catch invalid glTF files early, so users will report the issues to the appropiate glTF writers so they can fix them, at the cost of not being able to load many glTF files today.
  2. Be forgiving and try to load and amend malformed glTF files. It might look like a good idea because it lets you load most files today. But in the long run it will lead to an invironment full of malformed files floating around.

@vpenades vpenades closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants