Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation before write #42

Closed
torokze opened this issue Apr 16, 2020 · 4 comments
Closed

Validation before write #42

torokze opened this issue Apr 16, 2020 · 4 comments

Comments

@torokze
Copy link

torokze commented Apr 16, 2020

Hi,

There should be a way to select the validation strictness before write because it is so slow.
Something similar like during read. I wrote a gltf export for Revit and I have models to take more than an hour export time.

Thnx
Zolee

@vpenades
Copy link
Owner

I could add a property to disable validation when writing...

Although I would recomend not disabling validation: There's still a large number of issues with glTF in general, and the only way to know it is through validation.

@torokze
Copy link
Author

torokze commented Apr 16, 2020

Validation is good during the development to produce proper gltf. After that it's not unnecessary but skippable.

@vpenades
Copy link
Owner

I've just added a Validation property into WriteSettings, so you can disable validation when writing setting it to "Skip".

It will be available on the next nuget package release. I hope this will improve write performance a bit.

@torokze
Copy link
Author

torokze commented Apr 21, 2020

Thnx!!

I've already commented out for the release. After I validated all my buffers, bufferviews and accessors.
It is a huge performance boost.

Thnx again.

@torokze torokze closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants