stuck on block #5183999

[aaadipopt]

hey @vporton :)

any hints on how can we fix the #5183999 block issue -

open-bsc/ethcore/src/client/client.rs

Line 486 in a2c50e7

// FIXME: Otherwise the BSC block #5183999 verficiation fails.

thanks

[eyooooo]

posting here for others who may find this issue and want to help write a PR - looks like this project is not upgraded for the bsc hardfork that occurred at block 5184000.

Here is the GETH commit for that upgrade: bnb-chain/bsc@540ac2a#diff-5e832744a328dd85de712e88932a1f4c0e92e6c5cd5c9b17d76c762ec7a3b840

i am currently poking through this info to see if i can provide a useful PR. help is appreciated ;)

Thanks

[g4bwy]

Hi,

I'm not very familiar with openethereum's code, but chain forks/upgrades appear to be handled through json parameters (set in ethcore/res/ethereum/bsc.json), with corresponding handlers specified in ethcore/src/spec/spec.rs.

after this point, the fork parameters should probably be passed to the parlia engine (ethcore/src/engines/parlia/) and handled there... (not sure what to do exactly after that, but it's apparently mainly about upgrading some system contract bytecodes)

[g4bwy]

I guess an interesting example to handle such an upgrade would be found in musicoin's spec here: https://github.com/vporton/open-bsc/blob/main/ethcore/res/ethereum/musicoin.json#L13

[SeeSoftware]

Is there an update on this? i was trying to sync using this, because i wanted to save some space on the node but it got stuck on 5183999 :/

[g4bwy]

there have been some forks done to sync past the fork block (https://github.com/vorot93/open-bsc/tree/hardcode-mirrorsync and https://github.com/shortcircuit3/open-bsc/commits/alex/hardfork-mirrorsync notably), but they appear to fail later when importing block #5286006