Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue in substitution trees - check whether _nextVar really needs to keep growing forever #384

Closed
quickbeam123 opened this issue Jun 9, 2022 · 3 comments

Comments

@quickbeam123
Copy link
Collaborator

quickbeam123 commented Jun 9, 2022

(The problem being we would eventually run out _nextVars - which actually happened before, in an actual run, when SPEC_UPPER_BOUND was "only" 10000000, now it's about 50times larger.)

From Michael:

"We only "run out" of special variables because substitution trees do something a bit surprising with _nextVar to achieve freshness."

@MichaelRawson
Copy link
Contributor

@ibnyusuf @joe-hauns - I believe this can now be closed and SPEC_UPPER_BOUND can be deleted. We no longer have "very special vars" so all special variables are just the right amount of special. What do you think?

@joe-hauns
Copy link
Contributor

Yesss I think you're right. I think i just didn't spot that when i removed very special variables.

@MichaelRawson
Copy link
Contributor

Thanks! I'll add it to the default-constructor PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants