Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD: Setup automated lint + build system #146

Closed
vprusso opened this issue May 5, 2023 · 4 comments · Fixed by #154
Closed

CI/CD: Setup automated lint + build system #146

vprusso opened this issue May 5, 2023 · 4 comments · Fixed by #154
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects

Comments

@vprusso
Copy link
Owner

vprusso commented May 5, 2023

Previously, toqito made use of the previously free and supported Travis system for automated test, build, and lint pipelines.

At present, there is not an automated CI/CD solution in place. I don't have any particularly strong opinions on what technology stack is used here, so I'm all for discussing this at greater length to hone in on an ideal solution. It would be great for tests/linting/etc. to run automatically along with more in-depth reports on important codebase metrics (i.e. code-coverage, etc).

In addition to setting this up, the pipeline would need to successfully run the tests and be linted properly As the tests are currently passing (but not in an automated manner) and the code is fairly well-linted, there should not be too many additional tweaks here.

@vprusso vprusso added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 5, 2023
@vprusso vprusso added this to To do in toqito via automation May 5, 2023
@ryanprior
Copy link

ryanprior commented May 27, 2023

Hey @vprusso, I am getting started on this. My plan is to use GitHub Actions since it's built into the platform and generally well-regarded. I'll try and keep parity with your existing Travis steps. Then we can discuss what would be ideal if changes are needed. Does that make sense?

@ryanprior ryanprior mentioned this issue May 27, 2023
5 tasks
@vprusso
Copy link
Owner Author

vprusso commented May 29, 2023

Hey @vprusso, I am getting started on this. My plan is to use GitHub Actions since it's built into the platform and generally well-regarded. I'll try and keep parity with your existing Travis steps. Then we can discuss what would be ideal if changes are needed. Does that make sense?

That does make sense! Actually, I was hoping to move away from Travis completely and go entirely in the direction of GitHub actions as that seems to be the standard way of doing these things now.

toqito automation moved this from To do to Done May 30, 2023
@natestemen
Copy link

@vprusso please ensure the hacker responsible for resolving this issue is properly assigned, so they can receive the bounty!

@vprusso
Copy link
Owner Author

vprusso commented Jun 2, 2023

@vprusso please ensure the hacker responsible for resolving this issue is properly assigned, so they can receive the bounty!

Good catch! Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
toqito
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants