xsi:type currently requires a namespace, resulting in undefined if no… #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@newmaniese please fix the tests |
|
Updated, should be passing now. Sorry that it didn't pass the first time, Oracle's servers were down for the remote XSD, and I didn't realize it bailed on the first failure. |
|
@newmaniese build is still failing. can you take a look? |
|
Looking, thanks |
|
Managed to not push my changes. Please run it again and thank you. |
|
@newmaniese the build is still failing. please run these on your local machine. |
… XMLNS is defined. Making attributes working without namespace or xmlns definitions.
|
Tests were/are passing and missed a lint command. Fixed all good. Thanks |
|
Thanks, sorry for the back and forth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… XMLNS is defined. Making attributes working without namespace or xmlns definitions.