Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adminer.css #40

Closed
wants to merge 2 commits into from
Closed

Update adminer.css #40

wants to merge 2 commits into from

Conversation

milouse
Copy link
Contributor

@milouse milouse commented Apr 18, 2013

Fix to more visual bugs as asked in #38

Fix to more visual bugs as asked in #38
@milouse
Copy link
Contributor Author

milouse commented Apr 18, 2013

I have to admit this is a quick and elegant solution for both of your problems... but it uses advanced CSS selectors that might not work in IE <= 8. Moreover as it is a quick work I didn't take time to test in different browser. It is OK for the last version of Firefox but I have no idea for other browser 😕

@vrana
Copy link
Owner

vrana commented Apr 25, 2013

Select is fixed but permanent login neither in Firefox nor Chrome.
nette

@milouse
Copy link
Contributor Author

milouse commented Apr 25, 2013

The solution for this one is pretty obvious. I'm sorry I didn't understand what was the problem in your previous comment. It's about a feature I don't use and so I never saw the bug before.

So, the problem comes from the #menu p declaration at line 297 of my diff. You have to play with the white-space declaration.

If you remove it or declare it as normal (white-space: normal;) you will get this display:
white-space-normal

If you declare it as pre (white-space: pre;) you will get this display:
white-space-pre

I let you choose the best solution :)

@milouse
Copy link
Contributor Author

milouse commented Apr 25, 2013

Hold on.... in fact the bug is more complicated than I thought. There is a lot of hidden dependance under #menu p. For now my previous comment do not fix anything (in fact, it's more like it destroys things). Just tell me which of the two above solution you prefer and I'll come later with the right solution.

Ok, this one should fix the bug as in my second picture.
@vrana
Copy link
Owner

vrana commented Apr 26, 2013

white-space: pre;

@milouse
Copy link
Contributor Author

milouse commented Apr 26, 2013

Ok, so my last commit 1bf40fd should do the job.

@vrana
Copy link
Owner

vrana commented Apr 26, 2013

Thanks. One more thing - the logout button is missing:

logout

(the blue square shows where it should be)

@vrana vrana closed this Apr 26, 2013
@milouse
Copy link
Contributor Author

milouse commented Apr 30, 2013

I don't find it. As you can see for me I've the icon. On which page do you have this bug ?
adminer

@vrana
Copy link
Owner

vrana commented Apr 30, 2013

I've found the problem and fixed it. It was because of not enough specific selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants