Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] If there are multiple community repositories that have the common package, version list of another package will be wrong #369

Open
Sayamame-beans opened this issue Oct 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Sayamame-beans
Copy link

Describe the bug

If both anatawa12's and bd_'s community repositories have been added and are shown in VCC, version list of another package will be wrong.
This is because both need and have the "nadena.dev.ndmf" ("NDMF" short for "Non-Destructive Modular Framework" ) package.

To Reproduce

  1. Add community repositories which have common packages.
    This time, I use https://vpm.anatawa12.com/vpm.json and https://vpm.nadena.dev/vpm.json .
  2. Open "Manage Packages" page on some project.
  3. Check the package version lists.

This problem has different results depending on registration order of the community repositories.
If anatawa12's repo is earlier and bd_'s is later, "Modular Avatar" package appears to have version 1.0.2 which does not actually exist. (NDMF has version 1.0.2.)
If bd's repo is earlier and anatawa12's is later, "UdonSharp Migration Bug Fix" package appears to have version 1.0.0 and later which does not actually exist. (NDMF has version 1.0.0 and later.)

Expected behavior

All package version lists are shown correctly.

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.1.5

OS

Windows 10

Additional context

In anatawa12's repo, "UdonSharp Migration Bug Fix" package is written exactly before NDMF package.
In bd_'s repo, "Modular Avatar" package is written exactly before NDMF package.

@Sayamame-beans Sayamame-beans added the bug Something isn't working label Oct 14, 2023
@hai-vr
Copy link

hai-vr commented Oct 16, 2023

This issue also happens if the user enables multiple repo listings by the same author.
In my case, the pre-releases repo listing is a superset of bd_'s main repo listing.

Just as described in the initial bug report, this causes a package to be populated with non-existent versions numbers of a completely different package.

image

@orels1
Copy link
Contributor

orels1 commented Oct 16, 2023

Thanks for the report. Seems like the package merging logic is misbehaving and pushing versions into the wrong versions lists

@Sayamame-beans
Copy link
Author

Probably for the same reason, even if there is a newer version in the version list of common package, it may not be displayed.

This happens with anatawa12's repository and bd_'s prerelease repository( https://vpm.nadena.dev/vpm-prerelease.json ).
bd_'s prerelease repository has NDMF 1.3.0-rc.0 and anatawa12's repository does not, and anatawa12's is earlier and bd_'s is later in the VCC's repository order, NDMF 1.3.0-rc.0 is not shown.

VCC should merge the package lists with the same id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants