Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] VCC allows installing packages requires Unity 2021.3 to Unity 2019 projects #405

Closed
anatawa12 opened this issue Dec 14, 2023 · 1 comment
Labels
bug Something isn't working vpm-core Issues related to the vpm-core

Comments

@anatawa12
Copy link
Contributor

anatawa12 commented Dec 14, 2023

Describe the bug

VCC allows installing packages requires Unity 2021.3 to Unity 2019 projects.

Since VPM is convenient package distribution, some Generic Unity tools are also distributed as VPM package.
For such a packages, specifying unity field to 2021.3 is very reasonable since Unity 2021.3 is (legacy) LTS

To Reproduce

  1. Create Unity 2019 Project
  2. Add Anatawa12's Test VPM Repository for VCC's bug to your VCC
  3. Add Package Requires Unity 2021.3 to the project
  4. VCC allows installing Package Requires Unity 2021.3 to the project without any warning.

Expected behavior

VCC should

  • Warn Package Requires Unity 2021.3 is not compatible with 2019 and ask migrate to 2022
  • Warn Package Requires Unity 2021.3 is not compatible with 2019 and refuse installing the package

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.2.2

OS

Windows 11

Additional context

Related issues

There already is one real-world example of packages requires unity 2021.3.
That is TexTransTool v0.5.0-beta by Reina Sakiria.
In addition, my AvatarOptimizer is planned to require unity 2021.3 if it's still LTS when I drop Unity 2019.

@anatawa12 anatawa12 added the bug Something isn't working label Dec 14, 2023
@orels1 orels1 added the vpm-core Issues related to the vpm-core label Dec 14, 2023
@orels1
Copy link
Contributor

orels1 commented Feb 20, 2024

Available in VCC 2.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vpm-core Issues related to the vpm-core
Projects
None yet
Development

No branches or pull requests

2 participants