Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow users to override Packages/.gitignore #416

Open
Faxmashine opened this issue Jan 2, 2024 · 5 comments
Open

[FEATURE] Allow users to override Packages/.gitignore #416

Faxmashine opened this issue Jan 2, 2024 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Faxmashine
Copy link
Contributor

Currently, the VCC adds the following two lines to every project's Packages/.gitignore.

/*/
!com.vrchat.core.*/

This happens silently and disrupts the workflow of some users.

https://feedback.vrchat.com/creator-companion/p/dont-gitignore-entire-packages-folder

Users should be allowed to prevent the VCC from modifying Packages/.gitignore. Alternatively, the VCC could display or prompt or warning to inform users about modifications to the .gitignore file.

@Faxmashine Faxmashine added bug Something isn't working enhancement New feature or request labels Jan 2, 2024
@ChildoftheBeast
Copy link

i would love to see a flag for this getting added to VCC, as this disrupts all of my collaborative projects.

@advanced4
Copy link

yeah i'd really love to see this fixed, im not really sure what the purpose of this is because it just breaks every shared project

@techanon
Copy link

techanon commented May 5, 2024

For the time being, the work around is to explicitly unignore all prefix packages that you have in your project, and the re-ignore specific packages you don't want to commit.
For example:

/*/
!com.vrchat.core.*/
!at.*/
!com.*/
!dev.*/
!sh.*/
!tlp.*/
dev.onevr.vrworldtoolkit/

VCC currently just tries to make sure that the first two lines listed are in the gitignore. So we include them and add the more specific exclusions and inclusions as needed.

@orels1
Copy link
Contributor

orels1 commented May 5, 2024

The idea behind this was always to allow the VPM to re-resolve the pacakges instead of storing them in git directly, but due current resolve limitations I think it makes sense to make that optional for now

@ChildoftheBeast
Copy link

The idea behind this was always to allow the VPM to re-resolve the pacakges instead of storing them in git directly, but due current resolve limitations I think it makes sense to make that optional for now

i'm still not sure why it should work like this.
I get having the VPM manger pull the packages if they're not there, but i'm not sure as to why the gitignore needs to be there, as i don't feel that the package manager should be dictating what should and shouldn't go in to a github repo. I feel like that should be left up to the end user to decide and not be enforced, or at very minimum have a global opt-out for all your projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants