Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated use of _type in bulk API #65

Closed
fenimore opened this issue Feb 2, 2021 · 2 comments
Closed

Deprecated use of _type in bulk API #65

fenimore opened this issue Feb 2, 2021 · 2 comments

Comments

@fenimore
Copy link
Contributor

fenimore commented Feb 2, 2021

The elastic mock requires the elasticsearch.ElasticSearch.bulk method includes a _type field in the "actions" of the body parameter. (the body is newline separated action-document combinations)

https://github.com/vrcmarcos/elasticmock/blob/master/elasticmock/fake_elasticsearch.py#L331

When running this however with a Dockerized ES server I get (version 7.10.2)

elasticsearch/connection/base.py:193: ElasticsearchDeprecationWarning: [types removal] Specifying types in bulk requests is deprecated.

Here is the explanation for why: https://www.elastic.co/guide/en/elasticsearch/reference/7.x/removal-of-types.html

@vrcmarcos
Copy link
Owner

Hi!

Awesome note :) Ty for that!

Do you mind to send a PR fixing that? I'm not actively mainting this library, just merging the PRs

@fenimore
Copy link
Contributor Author

Ah I understand. As I won't do this either, by all means close the issue if you'd rather resolve it ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants