Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vignette has not any effect #20

Closed
lynx-seu opened this issue Jul 11, 2016 · 3 comments
Closed

vignette has not any effect #20

lynx-seu opened this issue Jul 11, 2016 · 3 comments

Comments

@lynx-seu
Copy link

under mac os x 10.11.5

@vrld
Copy link
Owner

vrld commented Oct 22, 2017

Hard to reporduce with the given information. Have you tried changing the parameters?

@lynx-seu
Copy link
Author

I found that it's ok in a Landscape. However, it doesn't has any effect in a Portrait

@vrld
Copy link
Owner

vrld commented Oct 23, 2017

Alright, I think I know what is going on: The vignette is computed using the aspect ratio width / height. In landscape, this is > 1 giving the expected result, but in portrait it does not. You can try to play around with the radius parameter (and maybe up the opacity) to see if that changes anything. In any case, I will update the shader to detect whether the format is landscape or portrait.

Good find!

@vrld vrld closed this as completed in 830d466 Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants