Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly Definition Files support? #19

Closed
SetoKaiba opened this issue Aug 5, 2018 · 3 comments
Closed

Assembly Definition Files support? #19

SetoKaiba opened this issue Aug 5, 2018 · 3 comments

Comments

@SetoKaiba
Copy link

I try to add Assembly Definition Files support to UniVRM.
https://github.com/dwango/UniVRM/blob/c110041088f788e90da96e8331ad4d86d7a5bc8b/Scripts/Format/VRMImporter.cs
It uses ShaderStore which is not public in UniGLTF.
It would be ok to use without asmdef.
But if I split the assemblies, the ShaderStore is not visible for VRM.

@SetoKaiba
Copy link
Author

Temporarily I just changed the ShaderStore from UniGLTF to public. And it's ok.
So, maybe a pr to UniGLTF to expose ShaderStore or achieve by another way.

@ousttrue
Copy link
Contributor

ousttrue commented Aug 5, 2018

I made ShaderStore public.

ousttrue/UniGLTF@522dbaa

@SetoKaiba
Copy link
Author

Thank you. It's resolved now. Ok to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants