Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle shipments #56

Closed
jcoupey opened this issue Mar 4, 2021 · 2 comments
Closed

Handle shipments #56

jcoupey opened this issue Mar 4, 2021 · 2 comments
Labels
Milestone

Comments

@jcoupey
Copy link
Contributor

jcoupey commented Mar 4, 2021

The frontend code was written before the shipment objects were added to the VROOM API, and was never upgraded to handle them. It would actually be a nice addition to the demo to be able to include shipments.

I see this as a two-step work:

  1. adding the notion of shipments in the code logic and have them added to the problem/request when directly submitting a json file as input while adjusting the solution display accordingly;
  2. actually allowing defining shipments through the UI.

The latter is probably useful too but more subject to design choices questions. And then also it would raise the question on how to manually define amounts, which we don't do in the UI for now.

@jcoupey
Copy link
Contributor Author

jcoupey commented Mar 19, 2021

First step done in #57.

@jcoupey
Copy link
Contributor Author

jcoupey commented Nov 30, 2022

Closing here as point 2 is probably not really relevant.

@jcoupey jcoupey closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant