Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with the latest stable version of Leaflet 1.9.1 #65

Open
egofer opened this issue Sep 30, 2022 · 1 comment
Open

Incompatibility with the latest stable version of Leaflet 1.9.1 #65

egofer opened this issue Sep 30, 2022 · 1 comment

Comments

@egofer
Copy link

egofer commented Sep 30, 2022

Running npm install installs the latest stable version of Leaflet 1.9.1. This gives problems when running vroom-frontend, showing the error:

Uncaught TypeError: L.hasOwnProperty is not a function

If Leaflet is downgraded to the previous stable version 1.8.0 in the package.json file, the error disappears.

@jcoupey
Copy link
Contributor

jcoupey commented Sep 30, 2022

Thanks for reporting. Our package.json setup does not pin to a given Leaflet version but uses "compatible with 1.3.4":

"leaflet": "^1.3.4",

If the compatibility is broken when moving from 1.8.0 to 1.9.1, then this sounds more like an upstream semver problem to me.

In any case, we could probably do with a round of dependency updates here, happy to look at any PR heading this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants