Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

medaka #188

Closed
1 of 3 tasks
laraPPr opened this issue Jul 31, 2023 · 12 comments
Closed
1 of 3 tasks

medaka #188

laraPPr opened this issue Jul 31, 2023 · 12 comments
Labels
conda Is supported in conda difficulty: medium software that likely require a fair amount of effort to support easyconfig Easyconfig is available priority: medium site:ugent Software installation request for UGent Tier-2

Comments

@laraPPr
Copy link
Collaborator

laraPPr commented Jul 31, 2023

@laraPPr laraPPr added difficulty: medium software that likely require a fair amount of effort to support priority: medium site:ugent Software installation request for UGent Tier-2 conda Is supported in conda easyconfig Easyconfig is available labels Jul 31, 2023
@RVerschoren
Copy link
Collaborator

We received a similar request, for a more recent medaka version (>=1.6, so 1.8.1 fits the bill). I am looking into an installation in foss-2022a. The intervaltree-python, ont-fast5-api, Racon packages will need an update as well in that case.

@RVerschoren
Copy link
Collaborator

Pushed current .eb files to a wip directory. Still having some trouble with the hard dependency on TensorFlow 2.8.

@boegel
Copy link
Contributor

boegel commented Aug 4, 2023

@RVerschoren It may be OK to just loosen up that strict version requirement for TensorFlow 2.8, see also my question to them on this a while ago: nanoporetech/medaka#124

@RVerschoren
Copy link
Collaborator

RVerschoren commented Aug 4, 2023

@boegel Thanks for the suggestion! It seems the error is in the sanity check part.

Both commands in the EasyConfig's sanity_check_commands work successfully, but a python -m pip check is also run. That blocks on the tensorflow~=2.8.0 line in requirements.txt.

I made a quick patch for that to accept other versions, and tested that with both TensorFlow 2.9 and 2.11 versions in foss-2022a.
The package now builds and installs a module fine for both. However, executing the make test mentioned in nanoporetech/medaka#124 only seems to run a coverage report in 3 collected tests. That coverage is about 18% of the code, so it fails to clear the 80% COVFAIL threshold they set in the Makefile.

Looking for the test files, I came across your other post nanoporetech/medaka#125. It seems they no longer ship a medaka/test directory and I did not find the CI pipeline they mentioned there (broken link to the walkthrough). I don't see much to test the installation here...

Edit: Requester linked me to the medaka/test/data in the GitHub repo itself. I will check it out.

@boegel
Copy link
Contributor

boegel commented Aug 24, 2023

@RVerschoren Any updates on this? We now also have 2 researchers who would like to see an updated version of medaka

@RVerschoren
Copy link
Collaborator

I re-installed with Pysam 0.19.1 (avoiding the version conflict we discussed during the last meeting).

Our requester is trying to test it, but keeps running into memory issues: with 3-day jobs that keep failing 2 days in, this is going slow. Unfortunately, it doesn't seem they have any other test input...

The medaka tests still report a coverage of 89% for me. Not ideal, but it looks to me like it installs and can be used as intended.

That said, I would appreciate additional testing on other sites, or other suggestions or advice on how to proceed.

@boegel
Copy link
Contributor

boegel commented Aug 24, 2023

@RVerschoren That sounds like it ready for tinkering with by researchers who actually need it...

Do you think it makes sense to open a pull request for your medaka easyconfig + whatever else is needed (patch files, easyconfigs for dependencies) to the central easyconfigs repo?

@RVerschoren
Copy link
Collaborator

@boegel There is nothing specific to UAntwerp or VSC in it, so yes, it can be shared, both in the VSC as well as the easybuilders-easyconfigs repository.

@RVerschoren
Copy link
Collaborator

Sent PR to central easyconfigs, easybuilders/easybuild-easyconfigs#18639

@boegel
Copy link
Contributor

boegel commented Aug 25, 2023

@RVerschoren PR merged, so the corresponding directory in wip branch can be cleaned up, and this issue can be closed

@boegel
Copy link
Contributor

boegel commented Aug 25, 2023

@RVerschoren I noticed there were several more recent releases of medaka, so I've done a trivial update in easybuilders/easybuild-easyconfigs#18651

@RVerschoren
Copy link
Collaborator

@boegel Thank you for the update, I missed the last releases.

I cleaned up the corresponding wip directory, so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda Is supported in conda difficulty: medium software that likely require a fair amount of effort to support easyconfig Easyconfig is available priority: medium site:ugent Software installation request for UGent Tier-2
Projects
None yet
Development

No branches or pull requests

3 participants