Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .exp extension for tcl icon #475

Closed
1 task done
garettmd opened this issue Nov 30, 2016 · 2 comments · Fixed by #478
Closed
1 task done

Add .exp extension for tcl icon #475

garettmd opened this issue Nov 30, 2016 · 2 comments · Fixed by #478

Comments

@garettmd
Copy link
Contributor

  • I'm sure this issue is not a duplicate?

Can we add the exp extension to the to the tcl icon set? This is to account for expect, an extension to the tcl language. This would require changing the supportedExtensions.js file's line as follows:

{ icon: 'tcl', extensions: ['tcl'] },

becomes

{ icon: 'tcl', extensions: ['tcl','exp'] },

And this would probably better suited to me just issuing a pull request, but I don't have any experiencing with building via npm, so I'm pretty sure I'd get it wrong.

@jens1o
Copy link
Member

jens1o commented Nov 30, 2016

You don't need to build, it's optional 😃

By the way: When you did installed npm, then open a commandline in that directory you've cloned and run the command npm run build. There you go!

@garettmd
Copy link
Contributor Author

garettmd commented Dec 1, 2016

Oh, well if it's that easy I'll just clone and do a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants