Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of Properties language id #565

Closed
1 task done
JimiC opened this issue Dec 21, 2016 · 5 comments
Closed
1 task done

Support of Properties language id #565

JimiC opened this issue Dec 21, 2016 · 5 comments

Comments

@JimiC
Copy link
Member

JimiC commented Dec 21, 2016

  • I'm sure this issue is not a duplicate?

Looking at the extension spec, if we are going to support this language id, I suspect it will create visual issues to what the user is currently familiar with.

Thoughts?

@JimiC
Copy link
Member Author

JimiC commented Dec 21, 2016

Should we raise an issue with vscode to ask them to move the git related filenames and extensions to git extension?

@jens1o
Copy link
Member

jens1o commented Dec 21, 2016

@JimiC Yeah, we absolutly should ask them. It's their mission to resolve this failure.

@robertohuertasm
Copy link
Member

I would also approve raising an issue with this. I don't know why they took the decision to add these extensions to the ini language and not to the git.

@JimiC
Copy link
Member Author

JimiC commented Jan 10, 2017

Finally found the time to raise the issue in vscode (microsoft/vscode#18358).

@JimiC
Copy link
Member Author

JimiC commented Jan 11, 2017

Closing this as resolved by @robertohuertasm PR (microsoft/vscode#17865).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants