Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After last update individual icons for jsx are gone #859

Closed
2 tasks
bigkrp opened this issue Apr 6, 2017 · 16 comments
Closed
2 tasks

After last update individual icons for jsx are gone #859

bigkrp opened this issue Apr 6, 2017 · 16 comments

Comments

@bigkrp
Copy link

bigkrp commented Apr 6, 2017

Gones jsx icon

default

@bigkrp bigkrp changed the title After last update шndividual icons for jsx are gone After last update individual icons for jsx are gone Apr 6, 2017
@jarshwah
Copy link

jarshwah commented Apr 6, 2017

Thank you! I wasn't sure if it was the update or something with my system. I'm also missing jsx icons.

@JamesRamm
Copy link

I have the same problem on Ubuntu. I dont even get JS icons - just a generic file icon.

@robertohuertasm
Copy link
Member

@JamesRamm I've just tested in Ubuntu and it seems to be working fine. I'd suggest you to reinstall the extension and see if it works.

@bigkrp bigkrp closed this as completed Apr 6, 2017
@bigkrp bigkrp reopened this Apr 6, 2017
@robertohuertasm
Copy link
Member

robertohuertasm commented Apr 6, 2017

jsreact

@bigkrp @JamesRamm can you let me know what you see when you have a jsx file selected? You should see something similar to the image above. Do you also have this Javascript React association?

@bigkrp
Copy link
Author

bigkrp commented Apr 6, 2017

@robertohuertasm
I have Javascript (Babel).
babel

When I try to select react, there are also no icon
no_react_js

@robertohuertasm
Copy link
Member

That would explain everything. jsx association is done via language id. Which babel extension are you using to get that language id?

@robertohuertasm
Copy link
Member

Is this one?

@bigkrp
Copy link
Author

bigkrp commented Apr 6, 2017

@robertohuertasm yes, i use this extension for colorize code!
Should i turn off this extension?

@robertohuertasm
Copy link
Member

The problem lies on how the babel extension is configured. It associates jsx files to javascript instead of javascriptreact.

Check this out to see how default vscode extensions deal with this.

Babel extension, instead, just does this other thing.

The way to fix it would be either manually associate jsx files again with Javascript React or tell the author of the plugin about this and see if he/she can fix it.

@robertohuertasm
Copy link
Member

On the other hand, if none of the other is an option to you, you can always use custom file associations by putting something similar to this in your settings.json.

"vsicons.associations.files": [
    { "icon": "reactjs",  "extensions": ["jsx"], "format": "svg" }
  ]

After that, F1 > Icons: Apply Icons Customization

@JimiC
Copy link
Member

JimiC commented Apr 6, 2017

Looks like our extension exposes bugs on other extensions due to the language id support.

@bigkrp
Copy link
Author

bigkrp commented Apr 6, 2017

@robertohuertasm thx! It's helped me!
I think it's problem, when vendor plugins could not get agree for filename associations between themselves

@bigkrp bigkrp closed this as completed Apr 6, 2017
@jarshwah
Copy link

jarshwah commented Apr 6, 2017

Thanks for leading me to the problem. For my issue, the problem extension was https://marketplace.visualstudio.com/items?itemName=TwentyChung.jsx which takes the file association, that doesn't map to an icon set. Either uninstalling that extension, or setting the following in settings.json solves the problem.

"files.associations": {
        "*.jsx": "javascriptreact"
    },

@mindwarrior
Copy link

For me it was as simple as click on the language shown at bottom right > Configure file association > select Javascript React.

@joyahmed
Copy link

joyahmed commented Jun 18, 2021

I added the followings in settings.json and it worked 

"material-icon-theme.activeIconPack": "react_redux",
"workbench.iconTheme": "material-icon-theme"

@robertohuertasm
Copy link
Member

@joyahmed It seems you're just using another theme.

@vscode-icons vscode-icons locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants