[Bug] v0.0.90 breaks workbench.action.compareEditor.nextChange and workbench.action.compareEditor.previousChange

[wenfangdu]

v0.0.90 is causing workbench.action.compareEditor.nextChange and workbench.action.compareEditor.previousChange not working properly (instead of jumping to the change, the viewport twitches), v0.0.89 does not, the code causing this issue is from #919.

I use these two shortcuts all the time when comparing diffs, so it was easy for me to spot:

[theol0403]

Please try with #993
If that doesn't work, try an earlier version with 11d0d77 (#993)

[wenfangdu]

@theol0403 #993 is working fine, is it a replacement for #919? If so, can #919 be reverted from the master branch?

[theol0403]

It is a continuation/upgrade/redo, no need for revert.

[theol0403]

I will close this as master isn't released and won't be until that PR

[wenfangdu]

Reproducible in 0.0.92+, not in 0.0.91, seems like a regression bug, please reopen this and take a look @theol0403

[theol0403]

Yeah #919 was released as I felt the pros outweighed the cons (proper lightspeed support). Originally I was not going to release as I also changed c-u/c-d bindings but I was able to separate the changes.

This will be fixed by #993. Until then use an older version of the extension, I made many incremental releases so it’s easy to pick.

[wenfangdu]

@theol0403 I've been stuck with v0.0.91 for nearly half a year now 😭, and can't use fixes/improvements in the newer versions, is there any way to patch this issue in the latest version?

[xiyaowong]

Same as #1365

[wenfangdu]

@xiyaowong It's not the same issue, and this issue was raised one year earlier than #1365, how come this issue got closed?

[xiyaowong]

These issues are all about viewport. I prefer to keep a newer issue. And that issue has a clearer description, and the discussion under this issue may be outdated and there is no effective information.

Also, does this issue still occur frequently?

[wenfangdu]

@xiyaowong Not reproducible in v1.1.5.