Global marks throwing errors and not reusing existing tabs

[roqvist]

NVIM v0.9.0
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

vscode-neovim v0.0.97

VSCode Version: Tried multiple; 1.78.2, 1.79.0-insider

Steps to reproduce:

• Open a VScode folder with two or more files

• Double click one of the files in the file browser to open it in a VSCode tab

• Double click another file in the file browser to open a second VSCode tab

• Place a global mark anywhere in the second opened tab, e.g. mA

• Move back to the first opened tab

• Try to move to the placed mark, e.g. 'A

  • Expected: The existing tab opens up, placing the cursor on the marked line

  • Actual: The file will be opened in a new (untitled) tab, cursor placed on top

    

• Close this untitled tab

• Manually click on the second tab (the one where you initially placed the global mark)

Two errors are shown:

2023-05-31T15:14:20.901Z BufferManager: nvim_win_set_cursor: Cursor position outside buffer

2023-05-31T15:14:20.903Z BufferManager: Unable to determine neovim windows id for editor viewColumn: 1, docUri: file:///c%3A/whatever/path/to/your/file

[owenstake]

+1

[martin-braun]

I'm thinking about installing Bookmarks and mapping all mark actions to the appropriate commands of it (it it supports auto-naming via keymaps that is). (nope)

It's unfortunate that VSCode doesn't have native bookmarks that we could leverage for this feature, and VSCode doesn't provide an API to jump to a specific line in a file while re-using opened tabs to do so, as far as I can tell.

[dangkhoipro]

I wonder if we can learn something from this bookmark extension https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks

[xiyaowong]

@dangkhoipro Will support vim native global marks in the future, but using other extensions is also a great option. You can invoke their commands through mappings.

[martin-braun]

@dangkhoipro No, it's closed source and you cannot reproduce Vim behavior closely in this one. Since it is closed source, there is no hope in modifying the extension so that it works with vim-alike mappings.

[dangkhoipro]

@dangkhoipro Will support vim native global marks in the future, but using other extensions is also a great option. You can invoke their commands through mappings.

I'm looking forward to it, thanks!

[spacian]

This extension seems to mirror Vim behavior quite well:
https://github.com/ExPixel/codemarks

It's still working like a charm for me, despite being 5 years old. @dangkhoipro @martin-braun

[Wozacosta]

@spacian ditto, using this one and working like a charm.

I did have to add this to my settings.json for it to work almost like on neovim:

  {
    "key": "'",
    "command": "codemarks.listMarks"
  },
  {
    "key": "m",
    "command": "codemarks.createMark",
    "when": "editorTextFocus"
  },
  {
    "key": "cmd+;",
    "command": "-codemarks.createMark",
    "when": "editorTextFocus"
  },

[martin-braun]

@spacian But it has no support for capital letters that will allow you to jump to a different file, or has it? Will vscode-neovim work properly with it?

@Wozacosta Thanks for the bindings.

[spacian]

@martin-braun it has all the features you want AFAIK. I'm using it specifically with vscode-neovim. I based a jumplist extension on it because I find the native vscode jump list rather unusable, I can walk you through the API used there: https://github.com/spacian/jumplist

The main function you are probably looking for is jumpTo(...) in src/jump_list_handler.ts.
vscode.window.showTextDocument(...) tries to open a text document by its uri. The uri is just saved when a mark or jump point is created.
The next 2 lines just make sure that the file was opened properly.
Then you create a selection based on the position of the mark (or jump point in my case) and set the active editor's selection to that selection with vscode.window.activeTextEditor.selection = selection.
Lastly, you center the new selection with vscode.window.activeTextEditor.revealRange(...)

A bunch of handling of file changes (which change mark or jump point positions) as well as file renames and deletions are handled rather naive in src/jump_list_updater.ts. But they work. And if it helps to make proper marks and a proper jump list vscode-neovim-native, all the better ;)