fix(cursor): re-add new VSCodeNotifyRange impl #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
Jul 30, 2023
| end | ||
|
|
||
| function M.notify_range(command, line1, line2, leaveSelection, ...) | ||
| return M.notify_extension('range-command', command, 'V', line1, line2, 1, 1, leaveSelection, { ... }) |
There was a problem hiding this comment.
Seems overwrought to have all these dedicated variants. call() and notify() could cover all these variations with a "kwargs" style dict parameter. That would also simplify the documentation. It also makes the calls, and usage, much easier to understand, instead of having 4+ positional args.
The variadic args ... could just be a list, there's no benefit to variadic args here: they are hard to visually parse vs the non-variadic args.
notify('foo', { arg1, arg2, … } {
line1=…, -- if `nil`, treat as non-range command
line2=…, -- if `nil`, treat as non-range command
col1=…, -- optional, treat as "line" if `nil` but `line1` was provided
col2=…, -- optional, treat as "line" if `nil` but `line2` was provided
}
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
VSCodeNotifyRangebut with a more concise and accurate impl. Fixes #1355, fixes #1351, fixes #1345.Also re-adds
VSCodeCommentaryand fixes a bug withVSCodeNotify.