Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cursor, visual): fix sync mouse selection #1451

Merged
merged 1 commit into from
Sep 17, 2023
Merged

fix(cursor, visual): fix sync mouse selection #1451

merged 1 commit into from
Sep 17, 2023

Conversation

xiyaowong
Copy link
Collaborator

Fixes #1450

theol0403
theol0403 reviewed Sep 17, 2023
View reviewed changes
Copy link
Member

@theol0403 theol0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the switch from setcharpos to setmark properly handle multi-byte characters?

In vscode, character positions != neovim byte positions.

@xiyaowong
Copy link
Collaborator Author

They are same, but nvim_buf_set_mark is more stable.

@theol0403 theol0403 merged commit bdf3b19 into vscode-neovim:master Sep 17, 2023
5 of 8 checks passed
@theol0403 theol0403 mentioned this pull request Sep 17, 2023
Merged
@xiyaowong xiyaowong deleted the fix/mouse-selection#1450 branch November 15, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theol0403 theol0403 theol0403 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Selecting text with the mouse may enter visual line mode instead of the regular visual mode
2 participants
@xiyaowong @theol0403