Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewport): reduce cursor jitter (temporary solution) #1459

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

xiyaowong
Copy link
Collaborator

@xiyaowong xiyaowong commented Sep 17, 2023

@theol0403 This is a minimal patch to reduce cursor jitter. Although it is a temporary solution, it is indeed effective. I have reviewed relevant issues and pull requests regarding the viewport, but unfortunately, I don’t have enough time to contribute further. As you mentioned, you are also busy. Therefore, I suggest using this temporary solution until someone can dedicate themselves to fixing the viewport. It’s better to have something than nothing. The cursor jitter significantly impairs the functionality of the frequently used jumping feature, resulting in a very bad user experience.

bad

scroll-definition-bad
scroll-diff-bad

so-so

scroll-definition
scroll-diff

@xiyaowong xiyaowong changed the title fix(viewport): fix cursor jitter (temporary solution) fix(viewport): reduce cursor jitter (temporary solution) Sep 17, 2023
Copy link
Member

@theol0403 theol0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your PRs and time, they are extremely appreciated. I agree this is good for the time being.

@theol0403 theol0403 merged commit 237e795 into vscode-neovim:master Sep 17, 2023
8 checks passed
@xiyaowong
Copy link
Collaborator Author

@theol0403 I guess I didn’t make it clear, I will still contribute PRs in my spare time, just that I won’t be able to focus all my energy on it like I did before (yes, I used to debug this during work hours too😂).

@theol0403
Copy link
Member

@xiyaowong awesome, good to know! (I also used some work time to debug my visual selection pr hahah)

As a student it's hard for me to find time to prioritise the project, especially since I don't code much during the school year (I'm taking mathematics & engineering), but I hope in a month or so I can chip away at some stuff.

My goals are:

  • make contributing doc so its easier for people to contribute
  • make viewport pr

@xiyaowong xiyaowong deleted the fix/fix-cursor-jitter branch November 15, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants