Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options to disable or change selection debounce time #1504

Merged

Conversation

xiyaowong
Copy link
Collaborator

new settings

  • vscode-neovim.normalSelectionDebounceTime
  • vscode-neovim.mouseSelectionDebounceTime

Resolve: #1475

@xiyaowong xiyaowong force-pushed the feat/options-for-visual-selection branch from 5004dbc to 9d23dff Compare October 8, 2023 06:50
@xiyaowong xiyaowong merged commit 2515e46 into vscode-neovim:master Oct 8, 2023
8 checks passed
@xiyaowong xiyaowong deleted the feat/options-for-visual-selection branch October 8, 2023 15:49
@theol0403
Copy link
Member

@xiyaowong out of curiosity, does disabling the mouse also disable cursor move on mouse click? I have a feeling that might still be nice to have even if selections don't enter visual mode.

@xiyaowong
Copy link
Collaborator Author

I did a simple test at that time and didn’t find any issues.

@justinmk
Copy link
Collaborator

justinmk commented Oct 9, 2023

Why are 2 options needed? Even one option is unfortunate, this now bakes-in a flaw as a permanent feature.

When are users supposed to use this, and how will they discover it?

@justinmk
Copy link
Collaborator

justinmk commented Oct 9, 2023

To avoid the need for 2 options this could instead be a factor or multiple, like 1x/1.5x/2x/3x. Or from a user's perspective it could be a "dial" or slider, i.e. a range from 1 to 100. Which then would be converted by vscode-neovim to appropriate values internally. No need for users to tweak the exact millisecond values.

@xiyaowong
Copy link
Collaborator Author

  1. These two options are completely unrelated.

  2. At present, I tend to solve the problem now and improve the document later.

  3. There is now a limited range of values for these two options.

@justinmk
Copy link
Collaborator

justinmk commented Oct 9, 2023

How are they unrelated? They both control the sync window between client/server. The fact that they control different internals is an implementation detail. When would a user adjust one of these values but not the other?

@xiyaowong
Copy link
Collaborator Author

xiyaowong commented Oct 9, 2023

About normal selection: #1403, #1409
About mouse selection: #1475

#1404

The current values range and the candidates are both good. Most users don’t even need to change them, but if they do, they will naturally discover these configurations. Like VSCode, it has a lot of undocumented configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: option to disable the synchronization of mouse selections
3 participants