feat: Add option statusLineSeparator
#1521
Conversation
Separator used by statusline
package.json
Outdated
| }, | ||
| "vscode-neovim.statusLineSeparator": { | ||
| "type": "string", | ||
| "default": " ", |
There was a problem hiding this comment.
Default should be |.
Not really sure this should be configurable though.
There was a problem hiding this comment.
Yeah, we may as well pick a good default
There was a problem hiding this comment.
It would be better to provide an option, for example, I prefer using spaces.
There was a problem hiding this comment.
@xiyaowong The problem is that a big focus of this extension is to reduce the lines of code and simplify, because currently it is difficult to maintain. This means thinking critically of features that don't bring much value. In this case, having an option provides small value.
If it would be better to simply have spaces for everyone, that would be fine.
We can merge it, but we should avoid adding configuration options that make little impact.
There was a problem hiding this comment.
Many users have different preferences for UI, such as me. The maintenance difficulty is not directly related to the new features and the number of lines of code. I agree that our primary goal is to reduce the code complexity as much as possible, but it is by no means relying on reducing the code and avoiding new configurations.
xiyaowong
force-pushed
the
feat/status_line_separator
branch
from
3d49672
to
8fe0c22
Compare
| } else { | ||
| this.statusBar.hide(); | ||
| } | ||
| // Always show the status line |
There was a problem hiding this comment.
+1 for this also. It was weird that the statusbar disappears.
There was a problem hiding this comment.
I think we need to adjust the priority. It looks strange right now. It should be displayed in the middle so that it doesn't cause other items to move around.
Separator used by statusline