feat: improved the nvim version check #1527
Conversation
xiyaowong
force-pushed
the
feat/improve-version-check
branch
from
71ce429
to
4bb3a97
Compare
| if (missOptions.length) errMsgs.push("Miss options: " + missOptions.join(", ") + ". "); | ||
| if (missFunctions.length) errMsgs.push("Miss functions: " + missFunctions.join(", ") + ". "); |
There was a problem hiding this comment.
s/Miss/missing
Not sure this message is helpful though. It's a roundabout way of saying "you need version X". It's simpler to just have a minimum version that we know contains the features required by vscode-neovim.
There was a problem hiding this comment.
It should be useful and users using the dev version can understand this information.
For example, the 0.9.0-dev version used in #1524
There was a problem hiding this comment.
For example, the 0.9.0-dev version used in #1524
But 0.9.0-dev should fail a check against 0.9.0. That's defined by semver. Whenever a prerelease tag (-dev) is present, it is strictly "less than" the release version.
There was a problem hiding this comment.
What if -dev contains the features we need?
There was a problem hiding this comment.
Why is it worth having complicated code (which must also be continually updated based on functions used by vscode-neovim) to support that edge case?
Nvim is intentionally "coarsely" versioned (as opposed to Vim, which has per-commit version numbers). There is zero reason to support users that happen to be on a random dev build.
Nvim during development is not stable. For example, when nvim_exec2 was added its signature may have changed in a later commit, so even if you check for the presence of nvim_exec2 that doesn't guarantee that you have the required version.
There was a problem hiding this comment.
That makes sense. Learned a lot from your detailed reply
No description provided.