fix: Cancel visual mode when switching editor #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trkoch
changed the title
trkoch
changed the title
trkoch
force-pushed
the
selection-other-group
branch
from
4fa93e6
to
4f1d064
Compare
trkoch
force-pushed
the
selection-other-group
branch
from
4f1d064
to
a6cd7ca
Compare
|
Note I "fixed" a test by changing the assertion. It was changed to |
|
Off-topic, I think there are too many logs now, one log per step...😂 |
xiyaowong
requested changes
Oct 29, 2023
@xiyaowong Yeah. It's pretty crazy. It did help me though with debugging this issue. |
theol0403
approved these changes
Oct 29, 2023
theol0403
approved these changes
Oct 29, 2023
justinmk
reviewed
Nov 13, 2023
| logger.debug( | ||
| `Cancel visual mode to prevent selection from previous editor to carry over to active editor`, | ||
| ); | ||
| await this.client.input("<Esc>"); |
There was a problem hiding this comment.
:help interrupt() may be more ideal than inputting ESC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1577