Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(visual): process selections in nvim #1603

Merged
merged 11 commits into from
Nov 14, 2023
Merged

refactor(visual): process selections in nvim #1603

merged 11 commits into from
Nov 14, 2023

Conversation

xiyaowong
Copy link
Collaborator

@xiyaowong xiyaowong commented Nov 13, 2023 •
edited

More concise and correct

@xiyaowong xiyaowong changed the title refactor(blockwise-visual): use builtin functions refactor(visual): process selections in nvim Nov 13, 2023
@xiyaowong xiyaowong marked this pull request as draft November 13, 2023 07:57
@xiyaowong
Copy link
Collaborator Author

The testing of Windows always fails inexplicably, but it runs normally when tested locally. 🤔🤨😕

@xiyaowong xiyaowong marked this pull request as ready for review November 13, 2023 15:15
@theol0403
Copy link
Member

You can't await lua code when processing regular cursor movements, it adds too much lag. Only await in visual mode. The cursor position should still be pushed to viewport_manager, not pulled from getpos.

@xiyaowong
Copy link
Collaborator Author

I know this. I've tested it. There's no difference. A single request takes only 1 ms

@theol0403
Copy link
Member

It felt to me like there was more jitter than usual when the computer was under load.

@vscode-neovim vscode-neovim locked and limited conversation to collaborators Nov 14, 2023
@vscode-neovim vscode-neovim unlocked this conversation Nov 14, 2023
@theol0403 theol0403 merged commit c202f52 into vscode-neovim:master Nov 14, 2023
8 checks passed
@theol0403 theol0403 mentioned this pull request Nov 14, 2023
Merged
@xiyaowong
Copy link
Collaborator Author

psychological effect

@xiyaowong xiyaowong deleted the refactor/blockwise-visual branch November 17, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theol0403 theol0403 theol0403 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiyaowong @theol0403