fix(highlight): remove duplicate visual selection highlight

[theol0403]

With #1597, applying the Visual highlight is no longer needed, we can entirely rely on vscode's selection.

[xiyaowong]

There are still some problems when multi-byte characters exist, especially when emoji exist. Might be better to keep Visual as feedback

[theol0403]

What kind of problems? Wouldn't it also cause cursor position problems? Not sure when the highlight will be more accurate than cursor position.

[xiyaowong]

However, most people do not use multi-byte characters, so deleting Visual is not a big deal.

In fact, Visual also has a potential function, that is, when the highlighting (or extmarks) is wrong, you can clear the wrong highlighting by selecting the area 😂

[xiyaowong]

Weird, I can't reproduce the previous bug again. Anyway, the main issue now is that it occurs when emojis are present. It can be fixed later when someone provides feedback.

[xiyaowong]

btw, there is a part of the logic here specifically for handling Visual. It is recommended to keep it.

vscode-neovim/src/highlight_provider.ts

Lines 153 to 155 in 6b58cd3

	// Treat all colors mixed with Visual as Visual to avoid defective rendering due to disjointed decoration ranges.
	private visualHighlightId?: number;
	private visualHighlightIds: number[] = [];

[theol0403]

Does clearing the visual highlight in this PR affect that?

[xiyaowong]

Some users may set up Visual by themselves.