fix(visual): Fix syncing vscode selection to nvim

[xiyaowong]

Fixes #1645

[justinmk]

VisualChanged will land soonish: neovim/neovim#26052 , does that avoid any of this extra code?

[xiyaowong]

a little

vscode-neovim/runtime/lua/vscode-neovim/cursor.lua

Lines 82 to 121 in ef81aec

	function M.setup_visual_changed(group)
	-- Simulate VisualChanged event
	-- TODO: https://github.com/neovim/neovim/issues/19708
	local visual_ns = api.nvim_create_namespace("vscode-neovim.visual.changed")
	local is_visual, last_visual_pos, last_curr_pos
	local function fire_visual_changed()
	fn.VSCodeExtensionNotify("visual-changed", api.nvim_get_current_win())
	end
	api.nvim_create_autocmd({ "ModeChanged" }, {
	group = group,
	callback = function(ev)
	local mode = api.nvim_get_mode().mode
	-- save current mode
	is_visual = mode:match("[vV\x16]")
	-- handle mode changes
	if ev.match:match("[vV\x16]") then
	last_visual_pos = fn.getpos("v")
	last_curr_pos = fn.getpos(".")
	fire_visual_changed()
	end
	end,
	})
	api.nvim_set_decoration_provider(visual_ns, {
	on_win = function()
	if is_visual then
	local visual_pos = fn.getpos("v")
	local curr_pos = fn.getpos(".")
	if not (vim.deep_equal(visual_pos, last_visual_pos) and vim.deep_equal(curr_pos, last_curr_pos)) then
	last_visual_pos = visual_pos
	last_curr_pos = curr_pos
	fire_visual_changed()
	end
	end
	end,
	})
	end

[xiyaowong]

this extra code?

Do you mean this pr? No

[YuruiHong]

Working for me, which is really helpful! Hopefully this will get merged soon.