feat(keybindings): Add keybindings for the hover widget #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- h/j/k/l - gg/G - C-f/C-b
xiyaowong
force-pushed
the
feat/keybindings-for-hover-widget
branch
from
8b6754b
to
33f381a
Compare
theol0403
reviewed
Dec 9, 2023
| You can add this to your keybindings.json: When hover is invisible, K is sent to nvim(show hover); when hover is | ||
| visible, press K again to focus the hover widget. | ||
|
|
||
| ```json |
There was a problem hiding this comment.
Should we just use this as default?
There was a problem hiding this comment.
Sure, it may not be needed, but we want to provide as complete and intuitive defaults as possible. If this is a natural and logical extension of the VSCode interface, manual configuration shouldn't be needed.
There was a problem hiding this comment.
I have no problem with it, most users should agree with this binding.
theol0403
approved these changes
Dec 9, 2023
|
I also tend to make best practices the default, at least this eases my own configuration :) |
xiyaowong
force-pushed
the
feat/keybindings-for-hover-widget
branch
from
4259ab5
to
1f9eef2
Compare
theol0403
reviewed
Dec 9, 2023
|
|
||
| ```json | ||
| { | ||
| "command": "editor.action.showHover", |
There was a problem hiding this comment.
Probably don't need to show this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1681