feat: Add option afterInitConfig
#1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theol0403
approved these changes
Dec 10, 2023
xiyaowong
force-pushed
the
feat/source-after-config
branch
from
41989ef
to
f5811fc
Compare
Config to be sourced after init config
xiyaowong
force-pushed
the
feat/source-after-config
branch
from
f5811fc
to
0d62191
Compare
xiyaowong
changed the title
initialPostConfigafterInitConfig
justinmk
reviewed
Dec 13, 2023
| const storagePath = this.extContext.globalStorageUri.fsPath; | ||
| if (!existsSync(storagePath)) mkdirSync(storagePath, { recursive: true }); | ||
| const vim = path.join(storagePath, "afterInitConfig.vim"); | ||
| writeFileSync(vim, config.afterInitConfig, { encoding: "utf8" }); |
There was a problem hiding this comment.
Writing a file should not be needed. Nvim has nvim_exec2, or you can :source a temporary buffer.
There was a problem hiding this comment.
Yes, I seem to have made it complicated (misled by the previous requirement of startup parameters in the #1350).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea: Save the config to a temporary file, and then use nvim's startup option -c and command source to load the file.
This configuration is suitable for simple operations such as configuring mappings in a temporary environment, but it can also execute any logic. The reason for using "after" is to avoid conflicting with existing configurations, and at the same time, it can be used to determine whether local configurations have been loaded in this configuration, thus executing different logic.
In addition, this configuration will not be automatically ignored based on neovimClean. Users can use "finish" on the first line to end the logic.
Close #1350