fix(buffer): prefer real path as buffer name #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiyaowong
force-pushed
the
feat/real-path-as-buffer-name
branch
2 times, most recently
from
479f03d
to
2d7c59f
Compare
justinmk
reviewed
Dec 11, 2023
theol0403
reviewed
Dec 11, 2023
| ---Translate from a Windows path to a WSL path | ||
| ---@param path string | ||
| ---@return string? | ||
| function M.wslpath(path) |
There was a problem hiding this comment.
Why do we need this, can't we use the ts wsl function?
There was a problem hiding this comment.
Executing wsl.exe creates a new connection to the instance each time, which is unnecessary. Since nvim is already running in the instance, it is more efficient and reasonable to use it as a bridge to execute Linux commands.
xiyaowong
force-pushed
the
feat/real-path-as-buffer-name
branch
from
2f0deb8
to
5d93237
Compare
theol0403
approved these changes
Dec 12, 2023
xiyaowong
force-pushed
the
feat/real-path-as-buffer-name
branch
from
5d93237
to
1b9d764
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #798