Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include time and scope in log file #1951

Merged
merged 1 commit into from
May 12, 2024

Conversation

xiyaowong
Copy link
Collaborator

No description provided.

@justinmk
Copy link
Collaborator

the title is misleading, because this is only for "console" ?

for logToOutputChannel, timestamp is redundant because vscode already shows a timestamp next to each message.

also, chore should be banned, it's a useless prefix. almost everything is either a "fix" or a "feature" (or a few other specific types). "chore" is over-used. this PR for example is a "fix".

@xiyaowong
Copy link
Collaborator Author

the title is misleading, because this is only for "console" ?

???

also, chore should be banned, it's a useless prefix. almost everything is either a "fix" or a "feature" (or a few other specific types). "chore" is over-used. this PR for example is a "fix".

Personally, I think it's just a small adjustment...

@xiyaowong xiyaowong changed the title chore: include time and scope in log file fix: include time and scope in log file May 10, 2024
@ollien
Copy link
Collaborator

ollien commented May 10, 2024

also, chore should be banned, it's a useless prefix. almost everything is either a "fix" or a "feature" (or a few other specific types). "chore" is over-used. this PR for example is a "fix".

In principle, I agree. The Angular ones are

  • build
  • chore
  • ci
  • docs:
  • style
  • refactor
  • perf
  • test

One could argue this PR is a feat, but I don't know if it's something that needs to be explicitly release-noted, either. I usually like chore for things that really couldn't fit into anything else, like linter changes/runs (since those aren't really "build", and perhaps aren't always "style")

@xiyaowong xiyaowong merged commit cccdf99 into vscode-neovim:master May 12, 2024
8 checks passed
@xiyaowong xiyaowong deleted the log-file branch May 12, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants