fix(incsearch): win cursor not properly revealed #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind giving a before/after screencast? I'm not clear exactly what this is fixing. (I have some morbid curiosity because I am attempting to address something potentially similar right now, so I wonder if our fixes combined are a complete solution...) |
|
It may not be the same issue. The difference is that currently only the tests for this PR will pass. 😹 |
|
Ah, this explains why my CI was failing inconsistently, then, even though it worked locally :) |
ollien
approved these changes
May 17, 2024
|
Maybe you are using nvim0.9 |
|
Merged. Approaching the weekend, reviews are slowing down. Not waiting this time. 🙈 |
|
I am. Go for it, as long as it still works with 0.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incsearchnot works in NVIM v0.10.0 #1969Temporary solution. Need to refactor cursor manager and viewport manager. Merge the logic and redefine the necessity of some custom events, such as visual-changed and window-scroll.
Note: Handling the win_viewport event directly in the cursor manager does not work