Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion in kha based project stopped working #345

Closed
sh-dave opened this issue May 16, 2019 · 0 comments
Closed

completion in kha based project stopped working #345

sh-dave opened this issue May 16, 2019 · 0 comments
Labels

Comments

@sh-dave
Copy link

sh-dave commented May 16, 2019

IRC log

9:43:13 AM - B: <Gama11> @ dave what kind of file paths are in completion requests with verbose mode enabled (https://github.com/vshaxe/vshaxe/wiki/Troubleshooting)?
9:43:43 AM - B: <Gama11> do they look like they exist?
9:49:36 AM - dave: yes, paths look ok. each one is listed twice though
9:55:07 AM - dave: hm, the --display argument might be wrong though. `--cwd` is set to `/xxx/build` and `--display` is `src/Main.hx` where it should be `../src/Main.hx` or `/xxx/src/Main.hx`?
9:58:21 AM - dave: (well --display is actually `src/Main.hx@0@diagnostics` in case the `@` matters)
10:05:11 AM - B: <Gama11> yes, I made some changes to cwd / handling of paths to fix a bunch of other issues..
10:05:43 AM - B: <Gama11> ironically `--cwd` is one of the things that was buggy.. 😃
10:07:11 AM - B: <Gama11> that's a bit awkward, maybe the language server needs to look for `--cwd` to find the correct relative paths of display files... :/
10:08:03 AM - B: <Gama11> this is one of the issues that was fixed https://github.com/vshaxe/vshaxe/issues/248
10:17:50 AM - B: <Gama11> I'm actually not sure there's a good fix for this in the general case, so maybe I'll end up having to revert the changes entirely 😦
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants