Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF8 values are not working. #30

Open
vshymanskyy opened this issue Mar 6, 2017 · 4 comments
Open

UTF8 values are not working. #30

vshymanskyy opened this issue Mar 6, 2017 · 4 comments

Comments

@vshymanskyy
Copy link
Owner

Need to check why Unicode notifications are not working and provide a fix/example.

@heisice
Copy link

heisice commented Mar 7, 2017

self.sock.write(data, 'binary');

then the unicode string is broken. but

self.sock.write(data, 'utf-8');

this is ok.
please review.

@vshymanskyy
Copy link
Owner Author

This doesn't look like a good solution for me...

self.sock.write(data)

also sends headers and other binary data, that we don't want to be encoded to UTF8

@ristomatti
Copy link

Any update on this?

@bestpika
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants