Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Gherkin 9 + all other decencies + drop unsupported node versions #223

Merged
merged 6 commits into from Apr 2, 2020
Merged

Update to Gherkin 9 + all other decencies + drop unsupported node versions #223

merged 6 commits into from Apr 2, 2020

Conversation

vsiakka
Copy link
Collaborator

@vsiakka vsiakka commented Apr 2, 2020

  • Update to Gherkin to 9
  • Update all other dependencies to latest
  • Drop versions of node that are no longer part of the node LTS
  • Fix everything that broke :X

@coveralls
Copy link
Collaborator

coveralls commented Apr 2, 2020 •
edited

Pull Request Test Coverage Report for Build 545

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 97.856%
Files with Coverage Reduction New Missed Lines %
dist/linter.js 6 90.22%
Totals Coverage Status
Change from base Build 538: 0.4%
Covered Lines: 703
Relevant Lines: 711
💛 - Coveralls

vsiakka
vsiakka commented Apr 2, 2020
View reviewed changes
README.md
@@ -45,19 +42,22 @@ Or check this:
| `no-duplicate-tags` | Disallows duplicate tags on the same Feature or Scenario |
| `no-empty-background` | Disallows features with backgrounds without steps |
| `no-empty-file` | Disallows empty feature files |
| `no-examples-in-scenarios` | Disallow the use of "Examples" in Scenarios, only allowed in Scenario Outlines |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is no longer crashing the gherkin parser

@vsiakka vsiakka changed the title Major version changes Update to Gherkin 9 + all other decencies + drop not supported node versions Apr 2, 2020
@vsiakka vsiakka changed the title Update to Gherkin 9 + all other decencies + drop not supported node versions Update to Gherkin 9 + all other decencies + drop unsupported node versions Apr 2, 2020
@vsiakka vsiakka merged commit 5b33a55 into master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vsiakka @coveralls