Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent written formula and implementation #55

Open
hieu325 opened this issue Dec 27, 2021 · 0 comments
Open

Inconsistent written formula and implementation #55

hieu325 opened this issue Dec 27, 2021 · 0 comments

Comments

@hieu325
Copy link

hieu325 commented Dec 27, 2021

In paper, it is written sin(\omega_0 W x + b).

But in implementation, the explore_siren notebook as well as modules.py, the output of linear layer is multiplied to \omega_0. In other words, sin(\omega_0 (Wx+b)).

I find this difference drastically changes the network convergence behavior. The actual implemented network performs much better.

Could you clarify this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant