Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"page width" detection for complex Java projects #135

Closed
skarzhevskyy opened this issue Jan 3, 2015 · 3 comments
Closed

"page width" detection for complex Java projects #135

skarzhevskyy opened this issue Jan 3, 2015 · 3 comments

Comments

@skarzhevskyy
Copy link

Related to issues #94.
After editing in poedit I see tones of changes in my po files. Its is hard to diff after translation.
"Preserve formatting of existing files" was on

I Look at the source code and apparently "page width" is detected using length of #: reference…
In my case this large project with java classes and standard xgettext do not wrap long paths in source code. Poedit takes this length as suggestion for page width in project.

example:

: com/pyx4j/site/client/backoffice/ui/prime/report/ReportControlPanelActionBar.java:86

msgid "Generating Report"
msgstr ""

consider that full project formatted at 88 columns..

Suggestion to ignore lenght of strings that do not have spaces e.g. are not actually wrapped.

@vslavik
Copy link
Owner

vslavik commented Jan 3, 2015

Could you please provide the full PO file (for testing)? TIA!

@skarzhevskyy
Copy link
Author

Here are the example files.
http://pyx4j.com/bug/poedit/sample-poEditWrap-before-edit.po
is considered 88 characters

http://pyx4j.com/bug/poedit/sample-poEditWrap-after-edit.po

03-01-2015 21-46-15

Regards,
Vlad

@vslavik
Copy link
Owner

vslavik commented Jan 5, 2015

Here are the example files.

Thanks, but I hoped for something more substantial that I could use to better test the fix — I don’t think this 3-items file is the one where you got “tons of changes”...

@vslavik vslavik closed this as completed in 246892f Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants