Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon-theme.cache being packaged #703

Closed
rffontenelle opened this issue Jun 7, 2021 · 4 comments
Closed

icon-theme.cache being packaged #703

rffontenelle opened this issue Jun 7, 2021 · 4 comments

Comments

@rffontenelle
Copy link
Contributor

rffontenelle commented Jun 7, 2021

/usr/share/icons/hicolor/icon-theme.cache is being packaged together with other relevant Poedit files during make install step. This file is generated when running gtk-update-icon-cache, which distros usually run on post-install phase of package installation, and usually it is not packaged together.

If possible to not install this file, I haven't found. Please enlighten if there is a well and I'll pass it downstream

Poedit version: 3.0
Distro: Arch Linux 64-bit
Package: poedit 1:3.0-1

I experienced this issue with the package provided in arch official repos, and then I built it myself to achieve the same result. I see the following output when installing the package:

$ sudo pacman -S poedit
resolving dependencies...
looking for conflicting packages...

Packages (1) poedit-1:3.0-1

Total Installed Size:  6.77 MiB

:: Proceed with installation? [Y/n] 
(1/1) checking keys in keyring                     [######################] 100%
(1/1) checking package integrity                   [######################] 100%
(1/1) loading package files                        [######################] 100%
(1/1) checking for file conflicts                  [######################] 100%
error: failed to commit transaction (conflicting files)
poedit: /usr/share/icons/hicolor/icon-theme.cache exists in filesystem
Errors occurred, no packages were upgraded.

Arch's package manager prints this error when the package is trying to replace existing file that does not belongs the package itself (e.g. in previous version).

@vslavik
Copy link
Owner

vslavik commented Jun 8, 2021

make install does not "package" anything - that's distribution's job.

make install installs Poedit and in doing so, updates the cache as it is supposed to.

Please direct complains about packaging to those responsible for the packages, as that is what is broken here, not Poedit's makefiles.

@vslavik vslavik closed this as completed Jun 8, 2021
@c72578
Copy link
Contributor

c72578 commented Jun 8, 2021

@rffontenelle Remark: In Fedora we remove the installed icon-theme.cache file before packaging.
e.g.: rm %{buildroot}/usr/share/icons/hicolor/icon-theme.cache
See: https://src.fedoraproject.org/rpms/poedit/c/dc4deb47ab540bf6524b0574ae2e9c51e17638bd?branch=rawhide

@rffontenelle
Copy link
Contributor Author

rffontenelle commented Jun 8, 2021

@c72578 Yeah, this solution was my initial thought but I've never saw an upstream software installing icon-theme.cache, so I thought it would worth reporting upstream as this could be an issue for many distros. I'll report this to downstream too.

@vslavik
Copy link
Owner

vslavik commented Mar 25, 2022

I was alerted that I was wrong about this by @super7ramp (details matter, and I misread them in the referenced tutorial) and they now fixed it in 6edfa2d

Sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants