WinSparkle dialogs not centred on parent application

[vslavik]

When using WinSparkle on a dual monitor setup and the application is used on the second monitor, all WinSparkle dialogs appear centered in the main monitor rather than the parent application.

Another reason to make the hosting app's main window parent of WinSparkle's dialogs is focus handling: WinSparkle window should stay on top of the app and not be hidden behind it.
The only complication: determining app's main window correctly.

[jasonfagan]

This is definitely something useful as I am currently having issues with the WinSparkle dialog being hidden behind the parent window. One solution might be to add a SetParentHWND function to and explicitly tell WinSparkle the main window, what are your thoughts?

[vslavik]

This is definitely something useful as I am currently having issues with the WinSparkle dialog being hidden behind the parent window.

But that has nothing at all to do with centering on windows, does it? If you have an issue with Z-order, please file a separate issue, preferably with at least some details and ideally a reproducible case (better yet, make that a PR with a fix ;). WinSparkle puts itself at the top of Z-order, so if that doesn't happen, it's clearly a bug.

what are your thoughts?

Speaking of this issue, i.e. centering, I'm against it — that's one more bit of data that the hosting app has to manage (app windows change in time). If anything can be done automatically, it should be. Turns out this is not even a hard problem: http://stackoverflow.com/questions/6202547/win32-get-main-wnd-handle-of-application

[jasonfagan]

No indeed you are right, just thought that if you were considering centering, then the z-ordering could also be in there. The z-ordering doesn't appear to work but that may have more to do with my application, I will certainly investigate and if there is a fix for it you'll get a PR :)

btw, thanks for a great library.

[vslavik]

The z-ordering doesn't appear to work

Related: likely cause of that is something along the lines of #41.

Centering fixed in ae99e5a and f5a0636