Allow to open PR in another repository

[fbiville]

No description provided.

[vsoch]

You should be able to do this, but you’ll need to use a personal access token.

[fbiville]

Thanks for your quick reply!
So if I've got repo A, branch X, I can already open PRs against repo B targeting branch Y?
How does the configuration look like in that case? I could not figure out.

[vsoch]

Use the environment variable PULL_REQUEST_REPOSITORY. Did you look at the README at all? https://github.com/vsoch/pull-request-action

[fbiville]

Yes I did, and I tried it without success.

Anyway, after reviewing GitHub API docs, I might be able to make it work with a combination of PULL_REQUEST_FROM_BRANCH (with the qualified branch name: user:branch and PULL_REQUEST_REPOSITORY.

This use case would be worth documenting in your README.

[fbiville]

I managed to make it work 🥳

Here is the pipeline I set up on the source repo (fbiville/commit-fwd-source-repo):

name: Commit forward
on:
  push:
    branches: ['4.3']
jobs:
  commit-forward:
    name: PullRequestAction
    runs-on: ubuntu-latest
    steps:
      - name: pull-request-action
        uses: vsoch/pull-request-action@master
        env:
          GITHUB_TOKEN: ${{ secrets.FORWARD_TOKEN }}
          # source
          PULL_REQUEST_FROM_BRANCH: "fbiville:4.3"
          # target
          PULL_REQUEST_REPOSITORY: fbiville-testing/commit-fwd-source-repo
          PULL_REQUEST_BRANCH: "4.3"

This forwards every commit as PR from the 4.3 branch of fbiville/commit-fwd-source-repo to the 4.3 branch of fbiville-testing/commit-fwd-source-repo.
Note that it required an explicit user-defined personal token for it to work, as you initially suggested.

[fbiville]

For consistency's sake, it might be worth adding a PULL_REQUEST_FROM_USER_OR_ORG, given there is already PULL_REQUEST_FROM_BRANCH? This would provide a better symmetry between the source and target repo/branch.

[vsoch]

@fbiville you don’t get to dictate that - the token decides. I’m not sure I see your logic here.

[fbiville]

What I'm trying to suggest is to allow both the current form:

          PULL_REQUEST_FROM_BRANCH: "fbiville:4.3"

and an alternative way:

          PULL_REQUEST_FROM_USER_OR_ORG: "fbiville"
          PULL_REQUEST_FROM_BRANCH: "4.3"

My PAT does not limit me to only github.com/fbiville, or? I could push to repositories of other organizations I'm part of, or am I mistaken?

[vsoch]

Ah I understand. That would only work if you trigger the workflow for any repository in an organization. How would you do that for one workflow?

[fbiville]

I'm already doing this to sync https://github.com/fbiville/commit-fwd-source-repo (where the above configuration lives) and its fork https://github.com/fbiville-testing/commit-fwd-source-repo.