Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLens keybindings? #331

Open
max-sixty opened this issue Aug 8, 2023 · 1 comment
Open

GitLens keybindings? #331

max-sixty opened this issue Aug 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@max-sixty
Copy link
Contributor

Problem

GitLens is great, has some superb features (some of which magit doesn't — such as opening the diff editor with comparisons to other commits).

But as per gitkraken/vscode-gitlens#2542, the keyboard navigation isn't great. Because it has high cardinality, VSpaceCode could be a great way of adding keyboard navigation.

Solution

What's the best way of adding VSpaceCode shortcuts for other extensions without adding the extension as a dependency?

  • Should they live here and only be active when the extension is installed?
  • Should they live in the extension and somehow be imported?
  • Is it easy for users to add a couple of shortcuts to their own config as a way of getting started?

(thanks again for the extension — I'm v grateful for it!)

@max-sixty max-sixty added the enhancement New feature or request label Aug 8, 2023
@max-sixty max-sixty changed the title Gitlens keybindings? GitLens keybindings? Aug 8, 2023
@stevenguh
Copy link
Member

The default answer that I have was to wait for "layer" mode, but I haven't been fully committed into that idea. There are many other issues that can be solve by this "layer" mode. I am trying to write up a doc describe a lot of these painpoints and trying to address them.

You can try using bindingOverrides meanwhile to modify the bindings, but the code doesn't support gating with extension installation/activation status.

https://vspacecode.github.io/docs/menu-customization/#addreplace

Some have opted to paste their bindings in either GH issue hoping that one day when we implemented layer mode, it will be picked up. Some have pasted their customized config to https://github.com/VSpaceCode/community-configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants